[move-vm][closures] Type and Value representation and serialization #15670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 6m total CI duration on this PR
|
This was referenced Jan 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
16 tasks
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
4972a5c to
2fed681
Compare
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
2fed681 to
9c0814c
Compare
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
9c0814c to
8b11451
Compare
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
8b11451 to
dcb6bc5
Compare
wrwg
force-pushed
the
wrwg/clos_values
branch
2 times, most recently
from
95728c9 to
6eea07c
Compare
wrwg
requested review from
georgemitenkov,
runtian-zhou,
vgao1996,
vineethk and
ziaptos
wrwg
requested review from
davidiw,
movekevin,
zekun000,
banool,
gregnazario and
0xmaayan
as code owners
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
dcb6bc5 to
bfc6f4c
Compare
wrwg
force-pushed
the
wrwg/clos_values
branch
from
6eea07c to
06363e0
Compare
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
bfc6f4c to
355525d
Compare
wrwg
force-pushed
the
wrwg/clos_values
branch
from
06363e0 to
90f0c08
Compare
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
2 times, most recently
from
13dfe03 to
92f22e0
Compare
[PR 3/n vm closures] This implements types and values for functions and closures, as well as serialization. For a detailed discussion, see the design doc. It does not yet implement the interpreter and runtime verification. Overview: - `MoveValue` and `MoveTypeLayout` are extended to represent closures and functions. A closure carries the function name, the closure mask, the function layout, and the captured arguments. The function layout enables serialization of the captured arguments without any context. - Runtime `Type` is extended by functions. - `ValueImpl` is extended by a closure variant. This representation uses `trait AbstractFunction` to represent the function value and implement core functionality like comparison and printing. The existing trait `FunctionValueExtension` is used to create `AbstracFunction` from the serialized representation. - Similar as with `MoveValue`, the serialized representation of `ValueImpl::Closure` contains the full function layout, enabling to deserialize the captured arguments context independently. This design has been chosen for robustness, avoiding a dependency of serialization from loaded functions, and to enable fully 'lazy' deserialization of closures. The later allows a contract to store hundreds of function values and on loading them from storage, avoiding loading the associated code until the moment the closure is actually executed. - `AbstractFunction` is implemented in the loader such that it can be either in 'unresolved' or in `resolved' state.
wrwg
force-pushed
the
wrwg/clos_type_conv
branch
from
92f22e0 to
23f4130
Compare
wrwg
force-pushed
the
wrwg/clos_values
branch
from
90f0c08 to
4ccfa58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[PR 4/n vm closures]
This implements types and values for functions and closures, as well as serialization. For a detailed discussion, see the design doc. It does not yet implement the interpreter and runtime verification.
Overview:
MoveValueandMoveTypeLayoutare extended to represent closures and functions. A closure carries the function name, the closure mask, the function layout, and the captured arguments. The function layout enables serialization of the captured arguments without any context.Typeis extended by functions.ValueImplis extended by a closure variant. This representation usestrait AbstractFunctionto represent the function value and implement core functionality like comparison and printing. The existing traitFunctionValueExtensionis used to createAbstracFunctionfrom the serialized representation.MoveValue, the serialized representation ofValueImpl::Closurecontains the full function layout, enabling to deserialize the captured arguments context independently. This design has been chosen for robustness, avoiding a dependency of serialization from loaded functions, and to enable fully 'lazy' deserialization of closures. The later allows a contract to store hundreds of function values and on loading them from storage, avoiding loading the associated code until the moment the closure is actually executed.AbstractFunctionis implemented in the loader such that it can be either in 'unresolved' or in `resolved' state.How Has This Been Tested?
Testing postponed until e2e wiring is up
Type of Change
Which Components or Systems Does This Change Impact?