Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more test transactions #15757

Merged
merged 1 commit into from
Jan 17, 2025
Merged

add more test transactions #15757

merged 1 commit into from
Jan 17, 2025

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Jan 16, 2025

Description

Adding more test transactions for higher processor test coverage

How Has This Been Tested?

(aptos-labs/aptos-indexer-processors#678)

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • [X ] Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • [ X] Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 16, 2025

⏱️ 2h 1m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
forge-e2e-test / forge 28m 🟥🟩
check-dynamic-deps 17m 🟩🟩🟩🟩🟩 (+2 more)
rust-cargo-deny 12m 🟩🟩🟩🟩🟩 (+2 more)
dispatch_event 8m 🟩
dispatch_event 6m 🟩
dispatch_event 6m 🟩
dispatch_event 6m 🟩
dispatch_event 6m 🟩
dispatch_event 6m 🟩
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 5m 🟩
test-target-determinator 4m 🟩
general-lints 3m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
fetch-last-released-docker-image-tag 2m 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 2m +50%
execution-performance / single-node-performance 9s 15m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm force-pushed the 01-16-add_more_test_transactions branch 4 times, most recently from 023b70b to ef80673 Compare January 16, 2025 21:59
@yuunlimm yuunlimm force-pushed the 01-16-add_more_test_transactions branch from ef80673 to e7484ce Compare January 16, 2025 22:28
@yuunlimm yuunlimm marked this pull request as ready for review January 16, 2025 22:47
@yuunlimm yuunlimm enabled auto-merge (squash) January 16, 2025 23:12

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> e7484cecd0e839b7056c01392523d29c25a8679b

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> e7484cecd0e839b7056c01392523d29c25a8679b (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 16858.65 txn/s, latency: 1994.97 ms, (p50: 1800 ms, p70: 1900, p90: 2400 ms, p99: 4600 ms), latency samples: 569580
2. Upgrading first Validator to new version: e7484cecd0e839b7056c01392523d29c25a8679b
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 2477.23 txn/s, latency: 10650.85 ms, (p50: 12800 ms, p70: 13600, p90: 13800 ms, p99: 13900 ms), latency samples: 54500
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4124.24 txn/s, latency: 8094.62 ms, (p50: 8600 ms, p70: 9400, p90: 9800 ms, p99: 10100 ms), latency samples: 141240
3. Upgrading rest of first batch to new version: e7484cecd0e839b7056c01392523d29c25a8679b
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4804.03 txn/s, latency: 6462.05 ms, (p50: 7200 ms, p70: 7800, p90: 8200 ms, p99: 8300 ms), latency samples: 95900
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5057.58 txn/s, latency: 6841.44 ms, (p50: 7500 ms, p70: 7600, p90: 7700 ms, p99: 7900 ms), latency samples: 176900
4. upgrading second batch to new version: e7484cecd0e839b7056c01392523d29c25a8679b
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8676.11 txn/s, latency: 3536.99 ms, (p50: 3800 ms, p70: 4000, p90: 4100 ms, p99: 4300 ms), latency samples: 156620
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8969.45 txn/s, latency: 3798.57 ms, (p50: 4100 ms, p70: 4200, p90: 4400 ms, p99: 4600 ms), latency samples: 295240
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> e7484cecd0e839b7056c01392523d29c25a8679b passed
Test Ok

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e7484cecd0e839b7056c01392523d29c25a8679b

two traffics test: inner traffic : committed: 14561.41 txn/s, latency: 2731.37 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5400 ms), latency samples: 5536580
two traffics test : committed: 100.00 txn/s, latency: 2209.42 ms, (p50: 1400 ms, p70: 2800, p90: 3900 ms, p99: 5700 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.397, avg: 0.974", "ConsensusProposalToOrdered: max: 0.299, avg: 0.294", "ConsensusOrderedToCommit: max: 0.354, avg: 0.341", "ConsensusProposalToCommit: max: 0.646, avg: 0.635"]
Max non-epoch-change gap was: 1 rounds at version 41064 (avg 0.00) [limit 4], 1.90s no progress at version 41064 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.59s no progress at version 2684611 (avg 0.59s) [limit 16].
Test Ok

@yuunlimm yuunlimm merged commit 0ba0bf6 into main Jan 17, 2025
89 checks passed
@yuunlimm yuunlimm deleted the 01-16-add_more_test_transactions branch January 17, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants