[lint] Don't lint needless mut reference on _ignored variables

[vineethk]

Description

In the following code (taken from a real world example), the linter warned about needless mutable reference:

fun foo(_x: &mut u64) {}

With this PR, we omit such warnings for variables that begin with _.

How Has This Been Tested?

Added a new test.

Type of Change

• Bug fix

Which Components or Systems Does This Change Impact?

• Move Linter

[trunk-io]

⏱️ 29m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
rust-doc-tests	7m	🟩
execution-performance / test-target-determinator	6m	🟩
test-target-determinator	5m	🟩
check-dynamic-deps	4m	🟩 🟩
rust-cargo-deny	3m	🟩 🟩
fetch-last-released-docker-image-tag	2m	🟩
general-lints	55s	🟩 🟩
semgrep/ci	50s	🟩 🟩
file_change_determinator	26s	🟩 🟩
file_change_determinator	13s	🟩
execution-performance / single-node-performance	10s	🟩
permission-check	6s	🟩 🟩
permission-check	4s	🟩 🟩
permission-check	3s	🟩
determine-docker-build-metadata	2s	🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / test-target-determinator	6m	5m
execution-performance / single-node-performance	10s	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[vineethk]

• [lint] Don't lint needless mut reference on _ignored variables #15762 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> 3328ce3b869255a08dec5ec62f7f63cffa196f1d

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> 3328ce3b869255a08dec5ec62f7f63cffa196f1d (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 18045.27 txn/s, latency: 1945.88 ms, (p50: 2100 ms, p70: 2100, p90: 2100 ms, p99: 2200 ms), latency samples: 578860
2. Upgrading first Validator to new version: 3328ce3b869255a08dec5ec62f7f63cffa196f1d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4932.48 txn/s, latency: 6277.54 ms, (p50: 7000 ms, p70: 7600, p90: 8000 ms, p99: 8000 ms), latency samples: 98140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4989.32 txn/s, latency: 6918.36 ms, (p50: 7700 ms, p70: 7700, p90: 7900 ms, p99: 8000 ms), latency samples: 176220
3. Upgrading rest of first batch to new version: 3328ce3b869255a08dec5ec62f7f63cffa196f1d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4336.99 txn/s, latency: 6938.85 ms, (p50: 7500 ms, p70: 8100, p90: 8500 ms, p99: 9100 ms), latency samples: 88080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4610.10 txn/s, latency: 7400.56 ms, (p50: 8200 ms, p70: 8300, p90: 8600 ms, p99: 8700 ms), latency samples: 164460
4. upgrading second batch to new version: 3328ce3b869255a08dec5ec62f7f63cffa196f1d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9050.76 txn/s, latency: 3355.77 ms, (p50: 3900 ms, p70: 4100, p90: 4200 ms, p99: 4300 ms), latency samples: 161940
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9158.87 txn/s, latency: 3736.08 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4600 ms), latency samples: 300380
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> 3328ce3b869255a08dec5ec62f7f63cffa196f1d passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 3328ce3b869255a08dec5ec62f7f63cffa196f1d

two traffics test: inner traffic : committed: 14859.17 txn/s, latency: 2672.66 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5649780
two traffics test : committed: 99.97 txn/s, latency: 1340.85 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 2100 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.515, avg: 1.479", "ConsensusProposalToOrdered: max: 0.297, avg: 0.289", "ConsensusOrderedToCommit: max: 0.325, avg: 0.317", "ConsensusProposalToCommit: max: 0.613, avg: 0.606"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 20179 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 6114378 (avg 0.57s) [limit 16].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking