Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add package manager installation method #15768

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xeonacid
Copy link

@Xeonacid Xeonacid commented Jan 17, 2025

Description

If the binary locates at /usr/bin, refuse to use aptos update aptos, and redirect to package manager.

How Has This Been Tested?

  • cargo build --release -p aptos with a old version patched like 6.0.0
  • sudo mv target/release/aptos /usr/bin/aptos
  • aptos update aptos

Key Areas to Review

This might be merged with the brew method.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 17, 2025

⏱️ 5s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 3s 🟥
permission-check 2s 🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, has someone been adding it to package managers?

If the binary locates at /usr/bin, refuse to use `aptos update aptos`,
and redirect to package manager.

This might be merged with the brew method.
@Xeonacid
Copy link
Author

Interesting, has someone been adding it to package managers?

Although not official on Arch Linux, it has been in the Arch Linux User Repository (AUR) and Arch Linux CN (A third-party binary repo).

@gregnazario gregnazario enabled auto-merge (squash) January 28, 2025 00:56

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on ea7dcd02d2b5525a739450ec283aea29730fd275

two traffics test: inner traffic : committed: 14852.42 txn/s, latency: 2667.95 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3200 ms), latency samples: 5647300
two traffics test : committed: 100.00 txn/s, latency: 1450.86 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 3300 ms), latency samples: 1700
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.479, avg: 1.417", "ConsensusProposalToOrdered: max: 0.296, avg: 0.290", "ConsensusOrderedToCommit: max: 0.410, avg: 0.399", "ConsensusProposalToCommit: max: 0.699, avg: 0.689"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.10s no progress at version 2098162 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.66s no progress at version 2098140 (avg 0.57s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 55909aa300b714e37df1113a239332c334cb2896 ==> ea7dcd02d2b5525a739450ec283aea29730fd275

Compatibility test results for 55909aa300b714e37df1113a239332c334cb2896 ==> ea7dcd02d2b5525a739450ec283aea29730fd275 (PR)
1. Check liveness of validators at old version: 55909aa300b714e37df1113a239332c334cb2896
compatibility::simple-validator-upgrade::liveness-check : committed: 6250.54 txn/s, submitted: 6250.71 txn/s, expired: 0.17 txn/s, latency: 2524.57 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3400 ms), latency samples: 402049
2. Upgrading first Validator to new version: ea7dcd02d2b5525a739450ec283aea29730fd275
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4355.93 txn/s, latency: 7186.42 ms, (p50: 8000 ms, p70: 8300, p90: 8600 ms, p99: 8900 ms), latency samples: 91620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4375.82 txn/s, latency: 7753.09 ms, (p50: 8700 ms, p70: 8800, p90: 8800 ms, p99: 9100 ms), latency samples: 154700
3. Upgrading rest of first batch to new version: ea7dcd02d2b5525a739450ec283aea29730fd275
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4146.85 txn/s, latency: 7518.38 ms, (p50: 8200 ms, p70: 8900, p90: 9400 ms, p99: 9500 ms), latency samples: 90560
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4189.71 txn/s, latency: 8110.45 ms, (p50: 9100 ms, p70: 9200, p90: 9400 ms, p99: 9500 ms), latency samples: 147320
4. upgrading second batch to new version: ea7dcd02d2b5525a739450ec283aea29730fd275
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7618.21 txn/s, latency: 3996.03 ms, (p50: 4500 ms, p70: 5000, p90: 5400 ms, p99: 5600 ms), latency samples: 139540
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2845.28 txn/s, submitted: 2845.40 txn/s, expired: 0.12 txn/s, latency: 4461.64 ms, (p50: 4800 ms, p70: 5100, p90: 5200 ms, p99: 5500 ms), latency samples: 256689
5. check swarm health
Compatibility test for 55909aa300b714e37df1113a239332c334cb2896 ==> ea7dcd02d2b5525a739450ec283aea29730fd275 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants