Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Struct and reference types in interpreter #15819

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Jan 27, 2025

Description

Small VM nits:

  • Change dynamic params for type creation to statics
  • Avoid arc clones and struct creations for runtyme checks where possible.

How Has This Been Tested?

Existing tests

Key Areas to Review

Check that interpreter logic has not been changed

Type of Change

  • Performance improvement
  • Refactoring

Which Components or Systems Does This Change Impact?

  • Move/Aptos Virtual Machine

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 27, 2025

⏱️ 2h 26m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 45m 🟩🟩
check-dynamic-deps 11m 🟩🟩🟩🟩
execution-performance / test-target-determinator 11m 🟩🟩
test-target-determinator 9m 🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
semgrep/ci 2m 🟩🟩🟩🟩
general-lints 1m 🟩🟩🟩
file_change_determinator 46s 🟩🟩🟩🟩
file_change_determinator 26s 🟩🟩
permission-check 12s 🟩🟩🟩🟩
permission-check 8s 🟩🟩🟩🟩
permission-check 5s 🟩🟩
determine-docker-build-metadata 5s 🟩🟩
check-branch-prefix 1s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 51m 15m +228%

settingsfeedbackdocs ⋅ learn more about trunk.io

@georgemitenkov georgemitenkov added the CICD:run-execution-performance-full-test Run execution performance test (full version) label Jan 27, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov georgemitenkov changed the title [move] Struct and refernece types in interpreter [move] Struct and reference types in interpreter Jan 27, 2025
@georgemitenkov georgemitenkov added CICD:run-execution-performance-test Run execution performance test and removed CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Jan 27, 2025
@georgemitenkov georgemitenkov force-pushed the george/struct-tys-interpreter branch from e85320f to c1aafd0 Compare January 29, 2025 14:42
@georgemitenkov georgemitenkov marked this pull request as ready for review January 29, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant