-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L monninger/fix movement #15838
Open
l-monninger
wants to merge
429
commits into
aptos-labs:main
Choose a base branch
from
movementlabsxyz:l-monninger/fix-movement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
L monninger/fix movement #15838
l-monninger
wants to merge
429
commits into
aptos-labs:main
from
movementlabsxyz:l-monninger/fix-movement
+44,061
−33,822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erry APT to MOVE
…n-vm-genesis Allow rewards percentage to be 0
…it-config Configure `movement init` to Movement devnet and testnet, remove mainnet for now
Check the tx events have been removed. This should include new block events, but we can't directly test that because the test block data generator used in aptos-db does not generate BlockMetadata transactions. Make variable naming more consistent in the tests.
…es-and-reorder aptos-db: `revert_commit` reordering and improvements
…it-config Change CLI init config branding from Aptos to Movement
Add finalized_block_height method for FinalityView, retrieving a previously set block height. This is needed for sanity checks.
…es-update Services Update
…eight-getter `finalized_block_height` getter for `FinalityView`
Remove all upstream GitHub workflows, save the one we're going to use with adaptations.
…orkflows Clean up .github/workflows
Replaced with instruction during choose network prompt.
Move Rate Limiter
…ease-builder Movement Labs Release Builder
l-monninger
requested review from
alinush,
heliuchuan,
rex1fernando,
msmouse,
lightmark,
grao1991,
JoshLind,
bchocho,
gregnazario,
banool,
sasha8,
gelash,
zekun000,
ibalajiarun,
davidiw,
movekevin,
junkil-park,
wrwg,
vgao1996,
georgemitenkov,
0xmaayan and
a team
as code owners
January 28, 2025 22:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist