Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L monninger/fix movement #15838

Open
wants to merge 429 commits into
base: main
Choose a base branch
from

Conversation

l-monninger
Copy link

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Andy Golay and others added 30 commits July 11, 2024 14:51
…n-vm-genesis

Allow rewards percentage to be 0
…it-config

Configure `movement init` to Movement devnet and testnet, remove mainnet for now
Check the tx events have been removed. This should
include new block events, but we can't directly test
that because the test block data generator used in aptos-db
does not generate BlockMetadata transactions.

Make variable naming more consistent in the tests.
…es-and-reorder

aptos-db: `revert_commit` reordering and improvements
…it-config

Change CLI init config branding from Aptos to Movement
Add finalized_block_height method for FinalityView,
retrieving a previously set block height.
This is needed for sanity checks.
…eight-getter

`finalized_block_height` getter for `FinalityView`
Remove all upstream GitHub workflows, save the one
we're going to use with adaptations.
Replaced with instruction during choose network prompt.
Copy link

trunk-io bot commented Jan 28, 2025

⏱️ 20s total CI duration on this PR

Job Cumulative Duration Recent Runs
permission-check 11s 🟥🟥🟥🟥
permission-check 9s 🟥🟥🟥🟥

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants