Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Enable call tree caches #15843

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[move] Enable call tree caches #15843

merged 2 commits into from
Jan 30, 2025

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 29, 2025

⏱️ 11h 26m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
single-node-performance 8h 17m 🟥🟥🟥🟥🟥 (+5 more)
execution-performance / single-node-performance 1h 14m 🟩🟩
test-target-determinator 48m 🟩🟩🟩🟩🟩 (+5 more)
rust-targeted-unit-tests 25m 🟩
execution-performance / test-target-determinator 9m 🟩🟩
check-dynamic-deps 9m 🟩🟩🟩🟩
rust-doc-tests 6m 🟩
rust-cargo-deny 5m 🟩🟩🟩
test-target-determinator 5m 🟩
general-lints 2m 🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 2m 🟩🟩🟩🟩
file_change_determinator 51s 🟩🟩🟩🟩
file_change_determinator 20s 🟩
permission-check 15s 🟩🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 49m 15m +226%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@georgemitenkov georgemitenkov marked this pull request as ready for review January 29, 2025 15:24
@georgemitenkov georgemitenkov added CICD:run-execution-performance-full-test Run execution performance test (full version) and removed CICD:run-execution-performance-full-test Run execution performance test (full version) labels Jan 30, 2025
@georgemitenkov georgemitenkov enabled auto-merge (squash) January 30, 2025 15:44

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c44dd45aa282d02e121cfa9372095cc9af3cbace

two traffics test: inner traffic : committed: 14665.40 txn/s, latency: 2703.04 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5576140
two traffics test : committed: 100.00 txn/s, latency: 1508.21 ms, (p50: 1400 ms, p70: 1500, p90: 1800 ms, p99: 2800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.442, avg: 1.356", "ConsensusProposalToOrdered: max: 0.306, avg: 0.293", "ConsensusOrderedToCommit: max: 0.443, avg: 0.417", "ConsensusProposalToCommit: max: 0.735, avg: 0.710"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.38s no progress at version 33724 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.66s no progress at version 2829143 (avg 0.66s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace

Compatibility test results for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace (PR)
1. Check liveness of validators at old version: 424ad1cab67f25b948e2090f274e2f55dba59dc9
compatibility::simple-validator-upgrade::liveness-check : committed: 11771.48 txn/s, latency: 2671.32 ms, (p50: 2600 ms, p70: 3000, p90: 3200 ms, p99: 3800 ms), latency samples: 385200
2. Upgrading first Validator to new version: c44dd45aa282d02e121cfa9372095cc9af3cbace
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3761.28 txn/s, latency: 8143.10 ms, (p50: 8800 ms, p70: 9600, p90: 10200 ms, p99: 10300 ms), latency samples: 83560
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3699.26 txn/s, latency: 9272.21 ms, (p50: 10300 ms, p70: 10500, p90: 10600 ms, p99: 10700 ms), latency samples: 133760
3. Upgrading rest of first batch to new version: c44dd45aa282d02e121cfa9372095cc9af3cbace
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4243.35 txn/s, latency: 7304.46 ms, (p50: 8100 ms, p70: 8700, p90: 9000 ms, p99: 9200 ms), latency samples: 91180
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4314.52 txn/s, latency: 7865.93 ms, (p50: 8800 ms, p70: 8900, p90: 9200 ms, p99: 9200 ms), latency samples: 152120
4. upgrading second batch to new version: c44dd45aa282d02e121cfa9372095cc9af3cbace
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 7184.60 txn/s, latency: 4255.76 ms, (p50: 4800 ms, p70: 5200, p90: 5800 ms, p99: 5900 ms), latency samples: 132600
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7122.24 txn/s, latency: 4787.35 ms, (p50: 5000 ms, p70: 5500, p90: 5800 ms, p99: 6200 ms), latency samples: 241420
5. check swarm health
Compatibility test for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace

Compatibility test results for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace (PR)
Upgrade the nodes to version: c44dd45aa282d02e121cfa9372095cc9af3cbace
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1699.65 txn/s, submitted: 1703.71 txn/s, failed submission: 4.07 txn/s, expired: 4.07 txn/s, latency: 1790.28 ms, (p50: 1700 ms, p70: 2000, p90: 2800 ms, p99: 4100 ms), latency samples: 150480
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1727.43 txn/s, submitted: 1731.48 txn/s, failed submission: 4.06 txn/s, expired: 4.06 txn/s, latency: 1737.32 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 153221
5. check swarm health
Compatibility test for 424ad1cab67f25b948e2090f274e2f55dba59dc9 ==> c44dd45aa282d02e121cfa9372095cc9af3cbace passed
Upgrade the remaining nodes to version: c44dd45aa282d02e121cfa9372095cc9af3cbace
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1147.05 txn/s, submitted: 1150.35 txn/s, failed submission: 3.30 txn/s, expired: 3.30 txn/s, latency: 2467.80 ms, (p50: 1500 ms, p70: 2000, p90: 4200 ms, p99: 12400 ms), latency samples: 104120
Test Ok

@georgemitenkov georgemitenkov merged commit 43f03ce into main Jan 30, 2025
114 of 136 checks passed
@georgemitenkov georgemitenkov deleted the george/enable-vm-caches branch January 30, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants