Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[account] Fix refreshes, and reduce excess API queries #985

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

gregnazario
Copy link
Contributor

Description

This removes repeated account resources queries. It removes the constant refresh on deleted resources, adds object ownership info easily accessible as well, and should handle mixed account / object.

Resolves #957

Related Links

Checklist

This removes repeated account resources queries.  It removes the
constant refresh on deleted resources, adds object ownership info
easily accessible as well, and should handle mixed account / object.

Resolves #957
@gregnazario gregnazario requested a review from ying-w January 13, 2025 04:02
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for aptos-explorer ready!

Name Link
🔨 Latest commit 6079d70
🔍 Latest deploy log https://app.netlify.com/sites/aptos-explorer/deploys/6784905fbf0caf0008da8a5c
😎 Deploy Preview https://deploy-preview-985--aptos-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ying-w ying-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes the example from issue

@gregnazario gregnazario merged commit e0928f7 into main Jan 13, 2025
7 checks passed
@gregnazario gregnazario deleted the fix-object-resources branch January 13, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] constant refresh when changing url to object that doesn't exist
2 participants