Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kube-enforcer): add deploymentAnnotations option to control deployment annotations #766

Open
wants to merge 1 commit into
base: 2022.4
Choose a base branch
from

Conversation

sjoukedv
Copy link
Contributor

this is useful for example with argo cd sync waves

Signed-off-by: Sjouke de Vries [email protected]

…oyment annotations

this is useful for example with argo cd sync waves

Signed-off-by: Sjouke de Vries <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2023

CLA assistant check
All committers have signed the CLA.

@semyonmor
Copy link
Collaborator

@sjoukedv
Can you pls add more details on how the deploymentAnnotations is different from the podAnnotation?

@sjoukedv
Copy link
Contributor Author

sjoukedv commented Oct 9, 2023

@sjoukedv Can you pls add more details on how the deploymentAnnotations is different from the podAnnotation?

@semyonmor Deployment is the 'root' object that is created against the Kubernetes api server. It will create a ReplicaSet which in terms create a Pod (where the pod also has at least one Container), so the annotation is on a completely different object.

I can elaborate on my use case; Argo CD will create all of our Kubernetes resources for us, so it is useful if we can add annotations to it to control the order it synces the deployment (see argocd sync waves). We need this because first we want to create the (new) certificate/ca in the secret and afterwards mount it into the pod. Otherwise the old value of the secret will be mounted. I have created to #784 address this issue with checksum/config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants