Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added policy to check vpc default for ec2 #1074

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
13 changes: 13 additions & 0 deletions avd_docs/aws/ec2/AVD-AWS-0183/docs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@

Determines whether the default VPC exists.

### Impact
<!-- Add Impact here -->

<!-- DO NOT CHANGE -->
{{ remediationActions }}

### Links
- https://docs.aws.amazon.com/vpc/latest/userguide/default-vpc.html


4 changes: 2 additions & 2 deletions avd_docs/kubernetes/general/AVD-KSV-0108/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Services with external IP addresses allows direct access from the internet and might expose risk for CVE-2020-8554

### Impact
Kubernetes API server in all versions allow an attacker who is able to create a ClusterIP service and set the spec.externalIPs field, to intercept traffic to that IP address. Additionally, an attacker who is able to patch the status (which is considered a privileged operation and should not typically be granted to users) of a LoadBalancer service can set the status.loadBalancer.ingress.ip to similar effect.
https://www.cvedetails.com/cve/CVE-2020-8554/
<!-- Add Impact here -->
SanaaYousaf marked this conversation as resolved.
Show resolved Hide resolved

SanaaYousaf marked this conversation as resolved.
Show resolved Hide resolved
<!-- DO NOT CHANGE -->
{{ remediationActions }}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# METADATA
# title: "Default VPC Exists"
# description: "Determines whether the default VPC exists."
# scope: package
# schemas:
# - input: schema.input
# related_resources:
# - https://docs.aws.amazon.com/vpc/latest/userguide/default-vpc.html
# custom:
# avd_id: AVD-AWS-0183
# provider: aws
# service: ec2
# severity: HIGH
# short_code: no-default-vpc
# recommended_action: "Move resources from the default VPC to a new VPC created for that application or resource group."
# input:
# selector:
# - type: cloud
package builtin.aws.ec2.aws0183

deny[res] {
def := input.aws.ec2.vpcs[_]
def.isdefault.value
res := result.new("Default VPC is used.", def.isdefault)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package builtin.aws.ec2.aws0183

test_detects_when_not_default{
r := deny with input as {"aws": {"ec2": {"vpcs": [{"isdefault": {"value": false}}]}}}
count(r) == 0
}

test_when_default {
r := deny with input as {"aws": {"ec2": {"vpcs": [{"isdefault": {"value": true}}]}}}
count(r) == 1
}