Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added policy to check image scan enable or not for ecr #1075

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
13 changes: 13 additions & 0 deletions avd_docs/aws/ecr/AVD-AWS-0191/docs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@

Ensure ECR repository has image scans disabled.

### Impact
<!-- Add Impact here -->

<!-- DO NOT CHANGE -->
{{ remediationActions }}

### Links
- https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-scanning.html


1 change: 1 addition & 0 deletions avd_docs/kubernetes/general/AVD-KSV-0108/docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Services with external IP addresses allows direct access from the internet and m
### Impact
Kubernetes API server in all versions allow an attacker who is able to create a ClusterIP service and set the spec.externalIPs field, to intercept traffic to that IP address. Additionally, an attacker who is able to patch the status (which is considered a privileged operation and should not typically be granted to users) of a LoadBalancer service can set the status.loadBalancer.ingress.ip to similar effect.
https://www.cvedetails.com/cve/CVE-2020-8554/

SanaaYousaf marked this conversation as resolved.
Show resolved Hide resolved
<!-- DO NOT CHANGE -->
{{ remediationActions }}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# METADATA
# title: "ECR Image Scans"
# description: "Ensure ECR repository has image scans disabled."
# scope: package
# schemas:
# - input: schema.input
# related_resources:
# - https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-scanning.html
# custom:
# avd_id: AVD-AWS-0191
# provider: aws
# service: ecr
# severity: HIGH
# short_code: enable-image-scans
# recommended_action: "Repository image scans should be enabled to ensure vulnerable software can be discovered and remediated as soon as possible."
# input:
# selector:
# - type: cloud
package builtin.aws.ecr.aws0191

deny[res] {
repo := input.aws.ecr.repositories[_]
not repo.imagescanning.scanonpush.value
res := result.new("Image scanning is not enabled.", repo.imagescanning.scanonpush)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package builtin.aws.ecr.aws0191

test_detects_when_disabled {
r := deny with input as {"aws": {"ecr": {"repositories": [{"imagescanning": {"scanonpush": {"value": false}}}]}}}
count(r) == 1
}

test_when_enabled {
r := deny with input as {"aws": {"ecr": {"repositories": [{"imagescanning": {"scanonpush": {"value": true}}}]}}}
count(r) == 0
}