Update rego title in OSS defsec Part2 #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mjshastha
force-pushed
the
MS_SLK-69409-new_rego_additions
branch
from
22d8c10
to
58ccd85
Compare
|
@chen-keinan PTAL after you are back, thanks. |
mjshastha
force-pushed
the
MS_SLK-69409-new_rego_additions
branch
from
58ccd85
to
c5ae09c
Compare
mjshastha
force-pushed
the
MS_SLK-69409-new_rego_additions
branch
from
c5ae09c
to
2c6c5a8
Compare
|
lgtm |
chen-keinan
previously approved these changes
Jul 26, 2023
mjshastha
force-pushed
the
MS_SLK-69409-new_rego_additions
branch
from
2c6c5a8
to
b1e1569
Compare
|
Looks like tests are failing and there's a merge conflict with upstream after the first PR was merged. |
…ently part of the commercial but not included in the oss. Additionally, there are certain checks in the oss where two checks are combined into a single check. However, in the commercial, these checks are treated as two separate checks. Therefore, we will be splitting the combined checks from the oss into two distinct checks to align with the commercial implementation.
simar7
force-pushed
the
MS_SLK-69409-new_rego_additions
branch
from
b1e1569
to
b818199
Compare
simar7
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we introduced three new rego checks to the oss. These checks are currently part of the commercial but not included in the oss.
Additionally, there are certain checks in the oss where two checks are combined into a single check. However, in the commercial, these checks are treated as two separate checks. Therefore, we will be splitting the combined checks from the oss into two distinct checks to align with the commercial implementation.
Resolves: SLK-69409