Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudformation): fix panic when use pseudo-parameters NoValue or NotificationARNs #1395

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(cloudformation): fix panic when use pseudo-parameters NoValue or NotificationARNs #1395

merged 3 commits into from
Jul 20, 2023

Conversation

nikpivkin
Copy link
Collaborator

@nikpivkin nikpivkin commented Jul 18, 2023 •
edited
Loading

Some pseudo-parameters are not strings, so when a parameter is cast to a string, panic occurs. Also, the values of the AWS::NotificationARNs parameter must be properties, not strings, to be able to use with Select or Join functions.

See aquasecurity/trivy#4843

@nikpivkin nikpivkin marked this pull request as ready for review July 18, 2023 07:14
@simar7
Copy link
Member

simar7 commented Jul 19, 2023

do we have an issue in trivy/defsec which this fixes?

@nikpivkin
Copy link
Collaborator Author

@simar7 I opened an issue

@simar7 simar7 enabled auto-merge (squash) July 20, 2023 12:02
@simar7 simar7 merged commit 9046b67 into aquasecurity:master Jul 20, 2023
8 checks passed
@simar7 simar7 mentioned this pull request Jul 20, 2023
Closed
@nikpivkin nikpivkin deleted the nik-pseudo-p branch July 20, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

@giorod3 giorod3 Awaiting requested review from giorod3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7