feat(aws): CloudTrail global service events rule #1401
Conversation
aisha-als
force-pushed
the
cloudtrail-global-services
branch
6 times, most recently
from
a4f406f
to
0c828fd
Compare
| BadExample: | ||
| GoodExample: |
There was a problem hiding this comment.
I'm curious why this has changed?
There was a problem hiding this comment.
I believe this should say GoodExample, after updating it on the policy it still needs to be updated on the auto generated docs. Updated from this policy as part of this PR: https://github.com/aquasecurity/defsec/blob/master/rules/cloud/policies/aws/cloudtrail/enable_all_regions.cf.go
| BadExample: | ||
| GoodExample: |
There was a problem hiding this comment.
Similar to my previous comment, the policy script has been updated as part of this PR and this should say GoodExample:
https://github.com/aquasecurity/defsec/blob/master/rules/cloud/policies/aws/cloudtrail/enable_at_rest_encryption.cf.go
| BadExample: | ||
| GoodExample: |
There was a problem hiding this comment.
Similar to my previous comment, the policy script has been updated as part of this PR and this should say GoodExample:
https://github.com/aquasecurity/defsec/blob/master/rules/cloud/policies/aws/cloudtrail/enable_log_validation.cf.go
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
github-actions
bot
added
the
stale
|
Thanks for reviewing and apologies for the late reply as I have been away. |
aisha-als
force-pushed
the
cloudtrail-global-services
branch
2 times, most recently
from
eabb8e3
to
1e9e05d
Compare
github-actions
bot
removed
the
stale
aisha-als
force-pushed
the
cloudtrail-global-services
branch
from
1e9e05d
to
dd5fc30
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
github-actions
bot
added
the
stale
Adding a new rule to check if Global Service Events are enabled in CloudTrail and have not been turned off as this value is enabled by default.
Links:
https://docs.aws.amazon.com/awscloudtrail/latest/userguide/cloudtrail-concepts.html#cloudtrail-concepts-global-service-events
https://registry.terraform.io/providers/rgeraskin/aws2/latest/docs/resources/cloudtrail#include_global_service_events
Also some minor fixes to example docs.