Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for IAM identity center permission set session duration #1514

Closed
wants to merge 11 commits into from

Conversation

gantta
Copy link

@gantta gantta commented Jan 5, 2024

Related to aquasecurity/trivy#5877

Adds new AWS service for IAM Identity Center Permission Set to address NIST CPRT SP 800-53 Release 5.1.1 AC-12

@gantta gantta requested a review from simar7 as a code owner January 5, 2024 15:00
@simar7
Copy link
Member

simar7 commented Jan 5, 2024

could you resolve the merge conflict?

@gantta
Copy link
Author

gantta commented Jan 5, 2024

merge conflict resolved. The Meta struct is not present in my branch in the /pkg/providers/aws/aws.go file so please confirm it should remain.

@simar7
Copy link
Member

simar7 commented Jan 10, 2024

merge conflict resolved. The Meta struct is not present in my branch in the /pkg/providers/aws/aws.go file so please confirm it should remain.

You have to rebase on latest master branch.

@gantta
Copy link
Author

gantta commented Jan 11, 2024

rebase complete. Should be good for review now.

@simar7
Copy link
Member

simar7 commented Jan 14, 2024

rebase complete. Should be good for review now.

tests are still red. Could you look into it? Might have to run go mod tidy and commit changes, if any.

@gantta
Copy link
Author

gantta commented Jan 15, 2024

go mod tidy is giving the following errors:

github.com/aquasecurity/defsec/internal/adapters/cloudformation/aws/iamidentitycenter imports
        github.com/aquasecurity/defsec/pkg/scanners/cloudformation/parser: no matching versions for query "latest"
github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter tested by
        github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter.test imports
        github.com/aquasecurity/defsec/internal/adapters/terraform/tftestutil: no matching versions for query "latest"

Not sure what I can do with this at this point.

@simar7
Copy link
Member

simar7 commented Jan 16, 2024

go mod tidy is giving the following errors:

github.com/aquasecurity/defsec/internal/adapters/cloudformation/aws/iamidentitycenter imports
        github.com/aquasecurity/defsec/pkg/scanners/cloudformation/parser: no matching versions for query "latest"
github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter tested by
        github.com/aquasecurity/defsec/internal/adapters/terraform/aws/iamidentitycenter.test imports
        github.com/aquasecurity/defsec/internal/adapters/terraform/tftestutil: no matching versions for query "latest"

Not sure what I can do with this at this point.

Sorry about that. We're in the middle of a project restructure and you caught us. Eventually the policies should live in the new repo https://github.com/aquasecurity/trivy-policies and any adapters in this repo https://github.com/aquasecurity/trivy-iac

I'll get to your PR shortly, I might have to recreate it for you but that's fine as I realize it's probably easier for me to do so and would also help us to document how someone can contribute externally. Appreciate the patience.

@gantta
Copy link
Author

gantta commented Feb 5, 2024

@simar7 Curious if there is any ETA that can be provided on when the new PR can go in?

@simar7
Copy link
Member

simar7 commented Feb 7, 2024

@simar7 Curious if there is any ETA that can be provided on when the new PR can go in?

We need these two changes merged before we can merge this PR.

  1. refactor(deps): Merge trivy-iac into Trivy trivy#6005
  2. refactor(deps): Merge defsec into Trivy trivy#6006

At the moment, I don't have an ETA for you but we'll get to it when the above are merged.

Copy link

github-actions bot commented Mar 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Mar 8, 2024
@gantta
Copy link
Author

gantta commented Mar 9, 2024

@simar7 any updates you can provide on ETA for when we can get this PR completed?

@github-actions github-actions bot removed the stale Stale issues will be closed within 7 days of this label being assigned label Mar 9, 2024
@simar7
Copy link
Member

simar7 commented Mar 14, 2024

@simar7 any updates you can provide on ETA for when we can get this PR completed?

@gantta defsec and other iac ancillary repos have been merged into trivy. If you could open a PR against the trivy repo we can help you merge it. Thanks for the understanding.

@gantta
Copy link
Author

gantta commented Mar 19, 2024

moving changes to trivvy repo

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Apr 18, 2024
@simar7 simar7 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues will be closed within 7 days of this label being assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants