upgrade docker cis benchmarks to latest(v1.6.0) #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the cis-1.3.1 and cis-1.6.0 both are meant for docker version 20.10 or latest, have removed cis-1.3.1 controls Have accommodated the Docker CIS benchmarks V1.6.0 into cis-1.6.0 and added the benchmarks version mapping if docker version 20.10 or later
KiranBodipi
force-pushed
the
kb-docker-cis-1.3.1-fix
branch
from
6d1fcb2
to
87e7b2c
Compare
|
Hi @chen-keinan could you please help to review and merge the PR. |
chen-keinan
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, docker-bench has docker cis benchmarks v1.3.1 as the latest implementation but as per cis v1.6.0 is the latest.
So we are upgrading the checks to latest v1.6.0 and removed the v1.3.1 checks as both are meant for docker version 20.10 or latest.
Also modified the benchmark version mapping to cis-1.6.0 for docker 20.10 or later such that docker-bench considers the latest benchmarks.