Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated KUBECTL_VERSION to 1.31.0 for fixing vulnerabilities #1690

Merged
merged 10 commits into from
Oct 3, 2024
Merged

Updated KUBECTL_VERSION to 1.31.0 for fixing vulnerabilities #1690

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fc601a
Bumped Go to 1.22.7 for fixing Critical/High vulberabilities
jdesouza Sep 25, 2024
d630013
Bumped Go to 1.22.7 for fixing Critical/High vulberabilities
jdesouza Sep 25, 2024
2da3c53
Bumped kubectl version for fixing vulnerabilities
jdesouza Sep 25, 2024
97c5771
Merge branch 'main' into main
jdesouza Sep 26, 2024
8d41e95
Fixed kubectl version
jdesouza Sep 27, 2024
d407bfa
Merge branch 'main' of github.com:jdesouza/kube-bench
jdesouza Sep 27, 2024
03d7283
Merge branch 'main' into main
jdesouza Sep 30, 2024
a4af123
Merge branch 'main' into main
afdesk Oct 1, 2024
7594761
Merge branch 'main' into main
afdesk Oct 3, 2024
375b90d
Update go.mod
jdesouza Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ RUN wget -O kubectl.sha256 "https://dl.k8s.io/release/v${KUBECTL_VERSION}/bin/li
RUN /bin/bash -c 'echo "$(<kubectl.sha256) /usr/local/bin/kubectl" | sha256sum -c -'
RUN chmod +x /usr/local/bin/kubectl

FROM alpine:3.20.0 AS run
FROM alpine:3.20.3 AS run
WORKDIR /opt/kube-bench/
# add GNU ps for -C, -o cmd, --no-headers support and add findutils to get GNU xargs
# https://github.com/aquasecurity/kube-bench/issues/109
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/aquasecurity/kube-bench

go 1.22
go 1.22.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should avoid updating this version in the go.mod file. This change will force all developers (including kube-bench maintainers and downstream project developers) to download go >=1.22.7.

@afdesk wdyt?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mozillazg I definitely agree with you!
my point was that we already use Go 1.22.7 for building in pipelines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Just reverted the go change. Now we have just the kubectl update


require (
github.com/aws/aws-sdk-go-v2 v1.31.0
Expand Down
2 changes: 1 addition & 1 deletion makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ uname := $(shell uname -s)
BUILDX_PLATFORM ?= linux/amd64,linux/arm64,linux/arm,linux/ppc64le,linux/s390x
DOCKER_ORGS ?= aquasec public.ecr.aws/aquasecurity
GOARCH ?= $@
KUBECTL_VERSION ?= 1.28.7
KUBECTL_VERSION ?= 1.31.0
ARCH ?= $(shell go env GOARCH)

ifneq ($(findstring Microsoft,$(shell uname -r)),)
Expand Down
Loading