Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: required fixes for rke-cis 1.7 / 1.28 / 1.29 #1792

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: required fixes for rke-cis 1.7 / 1.28 / 1.29 #1792

merged 2 commits into from
Feb 4, 2025
+9 −25

Conversation

ttousai
Copy link
Contributor

@ttousai ttousai commented Jan 28, 2025 •
edited by afdesk
Loading

Fixes #1780

guyjerby
guyjerby reviewed Jan 30, 2025
View reviewed changes
Copy link

@guyjerby guyjerby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ttousai ,
it seems that there is no update of check 4.2.8 for rke-cis-1.23 to skip, can you check?
in addition 1.3.7 - still shows wrong logic - it should be failed since no 127.0.0.1 but it passed

@ttousai
collection of fixes for rke, fixes aquasecurity#1780

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
a84692c
@afdesk afdesk changed the title A collection of fixes for rke, fixes #1780 fix: required fixes for rke-cis 1.7 / 1.28 / 1.29 Feb 4, 2025
@afdesk
Merge branch 'main' into 1780-fix-rke
Loading
Loading status checks…
1304698
@afdesk afdesk merged commit 26aaeec into aquasecurity:main Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afdesk afdesk

@guyjerby guyjerby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Required fixes for rke-cis 1.7 / 1.28 / 1.29
3 participants
@ttousai @afdesk @guyjerby