Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/immersed #458

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

WIP: Feature/immersed #458

wants to merge 23 commits into from

Conversation

danielsagi
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.

Contribution Guidelines

Please Read through the Contribution Guidelines.

Fixed Issues

Please mention any issues fixed in the PR by referencing it properly in the commit message.
As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue.
Please consult official github documentation for details.

Fixes #(issue)

"BEFORE" and "AFTER" output

To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".

BEFORE

Any Terminal Output Before Changes.

AFTER

Any Terminal Output Before Changes.

Contribution checklist

  • I have read the Contributing Guidelines.
  • The commits refer to an active issue in the repository.
  • I have added automated testing to cover this case.

Notes

Please mention if you have not checked any of the above boxes.

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #458 (40ebaa6) into main (6689005) will decrease coverage by 6.02%.
The diff coverage is 1.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   63.95%   57.93%   -6.03%     
==========================================
  Files          43       55      +12     
  Lines        2422     2679     +257     
==========================================
+ Hits         1549     1552       +3     
- Misses        873     1127     +254     
Impacted Files Coverage Δ
kube_hunter/console/__init__.py 0.00% <0.00%> (ø)
kube_hunter/console/auth/__init__.py 0.00% <0.00%> (ø)
kube_hunter/console/auth/auth.py 0.00% <0.00%> (ø)
kube_hunter/console/auth/types.py 0.00% <0.00%> (ø)
kube_hunter/console/discover/discover.py 0.00% <0.00%> (ø)
kube_hunter/console/env/__init__.py 0.00% <0.00%> (ø)
kube_hunter/console/env/env.py 0.00% <0.00%> (ø)
kube_hunter/console/env/types.py 0.00% <0.00%> (ø)
kube_hunter/console/general/__init__.py 0.00% <0.00%> (ø)
kube_hunter/console/general/console.py 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689005...40ebaa6. Read the comment docs.

py-go pushed a commit to py-go/kube-hunter that referenced this pull request Aug 29, 2021
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants