Fix: Convert host to str before adding to node_tables (#469) #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes issue #469, which occurs because
service.host
sometimes is anIPAddress
instead of a string.This resulted in a
TypeError: '<' not supported between instances of 'str' and 'IPAddress'
when PrettyTable tries to sort the entries.The fix was to always convert
service.host
to a string before adding it to the table.Maybe this is not the right place to fix this issue, as it might not be intended that
service.host
can be anIPAddress
, but it certainly was the easiest way to get rid of the crash.Fixed Issues
Fixes #469
"BEFORE" and "AFTER" output
BEFORE
AFTER
Crash is gone.
Contribution checklist
Notes
I have not added a test.