fix(proctree): possible sync.Once data race (#4307)

aquasecurity · Sep 25, 2024 · 604c391 · 604c391
1 parent 795a95b
commit 604c391
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/pkg/proctree/proctree.go b/pkg/proctree/proctree.go
@@ -143,6 +143,7 @@ func NewProcessTree(ctx context.Context, config ProcTreeConfig) (*ProcessTree, e
 	procTree := &ProcessTree{
 		processes:   processes,
 		threads:     threads,
+		procfsOnce:  new(sync.Once),
 		ctx:         ctx,
 		procfsQuery: config.ProcfsQuerying,
 	}

diff --git a/pkg/proctree/proctree_procfs.go b/pkg/proctree/proctree_procfs.go
@@ -46,9 +46,6 @@ func (pt *ProcessTree) FeedFromProcFSAsync(givenPid int) {
 		pt.procfsChan = make(chan int, 1000)
 		pt.feedFromProcFSLoop()
 	}
-	if pt.procfsOnce == nil {
-		pt.procfsOnce = new(sync.Once)
-	}
 
 	// feed the loop without blocking (if the loop is busy, given pid won't be processed)
 	select {