-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle zero-value types for unavailable fields - ArgMeta #4336
Handle zero-value types for unavailable fields - ArgMeta #4336
Conversation
@trvll do you mind testing? |
8a96e92
to
1cc78f0
Compare
I'll review this thoroughly tomorrow.
|
I don't believe so,
The Arg transmitted via grpc arrives lacking the Type since it's nil, then an incomplete Event Arg. When that end tries to convert it back to an event, it fails. Take a look at #4335. This assures that when an arg field not filled (whatever reason), it sets it with the correspondent zero value.
I believe we should indeed, in a chore PR, since it will require to change types and the whole core events fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just please add the comment documentation i've requested.
1cc78f0
to
bf7a4d0
Compare
bf7a4d0
to
34cd3f3
Compare
Some event arguments, such as "interpreter_*" from sched_process_exec, were not being populated because the kernel might not always provide them. This was causing errors during the gRPC proto conversion, as the values couldn't be asserted - they were nil. With this change, ArgMeta now holds the Zero value of the type, ensuring that assignment is always possible without requiring additional parsing in the pipeline. This also might help parsing since the Zero field will always have value, making it easier to assert its type instead of checking for Name field (string).
'git log --grep old_old_uid_t' in Linux kernel code didn't return any results.
34cd3f3
to
2f31471
Compare
/fast-forward |
Close: #4335
1. Explain what the PR does
2f31471 fix(events): setuid16 arg name typo
4737625 fix: handle zero-value types for unavailable fields
41eeb29 chore(go.mod): bump types to latest version
2f31471 fix(events): setuid16 arg name typo
4737625 fix: handle zero-value types for unavailable fields
2. Explain how to test it
3. Other comments