Signatures helpers improvement #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag helpers previously took a string argument to test against possible flag configurations. New implementation takes the integer form and makes the test with the bit flag directly. Co-authored-by: Geyslan Gregório <[email protected]>
Add a new uint argument helpers, which extracts a data argument from an event by name and returns it if it was one of the uint types. Additionally, add further checks for int64 and int types in the already existing int argument helper.
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required by: #4331
1. Explain what the PR does
0b23713 feat(helpers): robust int and uint arg helpers
4d5e47d feat(helpers): unparsed flag helpers
2. Explain how to test it
3. Other comments