Refactor: Restructure event and rename context #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two key changes to the Tracee event structure: - Renames the `context` field to `workload` to provide a more specific and clear description of the execution environment. - Moves the `triggeredBy` field from the `data` section to the root of the event structure. This ensures the `data` section is strictly defined by the event-specific schema, improving consistency and clarity. These changes constitute a breaking change to the API. However, as `traceectl` is not yet merged, it is acceptable to introduce this breaking change now to avoid future complications.
geyslan
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
LGTM. @ShohamBit would you mind testing traceectl with this change?
geyslan
added
candidate/v0.22.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This commit introduces two key changes to the Tracee event structure:
contextfield toworkloadto provide a more specific and clear description of the execution environment.triggeredByfield from thedatasection to the root of the event structure. This ensures thedatasection is strictly defined by the event-specific schema, improving consistency and clarity.These changes constitute a breaking change to the API. However, as
traceectlis not yet merged, it is acceptable to introduce this breaking change now to avoid future complications.2. Explain how to test it
3. Other comments