Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helpers): GetProtoHTTPRequestByName/GetProtoHTTPResponseByName #4392

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

rscampos
Copy link
Collaborator

1. Explain what the PR does

def5b45 feat(helpers): net_packet_http request/response

- Add `GetProtoHTTPRequestByName` to get http request header from the
  event `net_packet_http_request`;
- Add `GetProtoHTTPResponseByName` to get http response header from the
  event `net_packet_http_response`;

2. Explain how to test it

3. Other comments

Signature helpers function necessary for #4354.

- Add `GetProtoHTTPRequestByName` to get http request header from the
  event `net_packet_http_request`;
- Add `GetProtoHTTPResponseByName` to get http response header from the
  event `net_packet_http_response`;
@rscampos
Copy link
Collaborator Author

@NDStrahilevitz It's just the type for sig helpers... I'm sorry for the delay on this.

@rscampos rscampos changed the title feat(helpers): net_packet_http request/response feat(helpers): GetProtoHTTPRequestByName/GetProtoHTTPResponseByName Nov 25, 2024
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rscampos rscampos merged commit d1a6507 into aquasecurity:main Nov 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants