feat(events): add stack_pivot event #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/ebpf
kind/documentation
area/testing
area/events
area/filtering
labels
oshaked1
force-pushed
the
stack_pivot
branch
2 times, most recently
from
c8de2ac to
b578701
Compare
oshaked1
force-pushed
the
stack_pivot
branch
3 times, most recently
from
9c9abd0 to
b10db98
Compare
yanivagman
reviewed
Jan 15, 2025
pkg/ebpf/c/tracee.bpf.c
Outdated
Comment on lines
5288
to
5343
| const char *vma_type_str = get_vma_type_str(get_vma_type(task, vma)); | ||
| unsigned long vma_start = BPF_CORE_READ(vma, vm_start); | ||
| unsigned long vma_size = BPF_CORE_READ(vma, vm_end) - vma_start; | ||
| unsigned long vma_flags = BPF_CORE_READ(vma, vm_flags); | ||
|
|
||
| switch (vma_type) { | ||
| case VMA_STACK: | ||
| vma_type_str = "main stack"; | ||
| break; | ||
| case VMA_THREAD_STACK: | ||
| vma_type_str = "thread stack"; | ||
| break; | ||
| case VMA_HEAP: | ||
| vma_type_str = "heap"; | ||
| break; | ||
| case VMA_GOLANG_HEAP: | ||
| // Goroutine stacks are allocated on the golang heap | ||
| vma_type_str = "golang heap/stack"; | ||
| break; | ||
| case VMA_ANON: | ||
| vma_type_str = "anonymous"; | ||
| break; | ||
| case VMA_VDSO: | ||
| vma_type_str = "vdso"; | ||
| break; | ||
| default: | ||
| vma_type_str = "unknown"; | ||
| break; | ||
| } | ||
| save_to_submit_buf(&p.event->args_buf, &syscall, sizeof(syscall), 0); | ||
| save_to_submit_buf(&p.event->args_buf, &ip, sizeof(ip), 1); | ||
| save_str_to_buf(&p.event->args_buf, (void *) vma_type_str, 2); | ||
| save_to_submit_buf(&p.event->args_buf, &vma_start, sizeof(vma_start), 3); | ||
| save_to_submit_buf(&p.event->args_buf, &vma_size, sizeof(vma_size), 4); | ||
| save_to_submit_buf(&p.event->args_buf, &vma_flags, sizeof(vma_flags), 5); |
There was a problem hiding this comment.
Your commits are mixing stack_pivot and suspicious_syscalls events.
This commit states it adds the stack pivot event, however, it also modifies logic of the suspicious syscall event.
There was a problem hiding this comment.
The only thing I changed is moving the logic to get vma_type_str into a separate function (because it's used by check_stack_pivot as well).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
oshaked1
force-pushed
the
stack_pivot
branch
2 times, most recently
from
912719f to
8e06ee3
Compare
Convert `check_syscall_source` to use this probe instead of having a dedicated probe. The attachment mechansim is also generic and supports the registration of future syscall checkers.
Golang heaps can be determined by a pattern in the address, dictated by address hints supplied to mmap while allocating memory for them. Thread stacks can be identified by tracking the stack VMA for all newly created threads.
This event detects usage of the stack pivot technique used during ROP exploits by checking the user's stack pointer at selected syscalls. If the stack pointer does not point to the stack, an event is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4404
1. Explain what the PR does
Add
stack_pivotevent, which detects usage of the stack pivoting technique as part of a ROP exploit, by monitoring selected syscalls and verifying the location of the stack pointer.2. Explain how to test it
Run tracee as follows:
Compile and run the tester program:
After 15 seconds a stack pivot event should be triggered.
3. Other comments
Like
suspicious_syscall_source, this event makes use of event parameters to determine which syscalls should be monitored. The new probe group created forsuspicious_syscall_sourcewas made generic for "syscall checker" events, and each time a probe is triggered only the "checkers" which selected that syscall are run.