Skip to content

Commit

Permalink
Add release for Wireshark 4.4.0
Browse files Browse the repository at this point in the history
Disable newly added minizipng for github actions builds because it requires bcrypt which is not found and seems to be a hassle to install.
This has no effect on the built plugins.
  • Loading branch information
oshaked1 committed Aug 29, 2024
1 parent dee7e78 commit f049a52
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ runs:
cd build
set WIRESHARK_BASE_DIR=..\
set WIRESHARK_QT6_PREFIX_PATH=$QT_ROOT_DIR
cmake -G "Visual Studio 17 2022" -A x64 ..\wireshark
cmake -G "Visual Studio 17 2022" -A x64 -DENABLE_MINIZIPNG=Off ..\wireshark
shell: cmd
- name: Install headers
run: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
matrix:
# macos-14 is ARM64, macos-13 is x86-64
os: [ubuntu-latest, macos-14, macos-13, windows-latest]
wireshark_version: [wireshark-4.2.6]
wireshark_version: [wireshark-4.2.6, wireshark-4.4.0]
include:
# Ubuntu 22.04 Wireshark package version
- os: ubuntu-latest
Expand Down Expand Up @@ -79,6 +79,7 @@ jobs:
set WIRESHARK_BASE_DIR=%CD%
set WIRESHARK_QT6_PREFIX_PATH=$QT_ROOT_DIR
set WERROR=y
set ENABLE_MINIZIPNG=Off
call scripts\cmake.bat
call scripts\build.bat
shell: cmd
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
matrix:
# macos-14 is ARM64, macos-13 is x86-64
os: [ubuntu-latest, macos-14, macos-13, windows-latest]
wireshark_version: [wireshark-4.2.6]
wireshark_version: [wireshark-4.2.6, wireshark-4.4.0]
include:
# Ubuntu 22.04 Wireshark package version
- os: ubuntu-latest
Expand Down Expand Up @@ -104,6 +104,7 @@ jobs:
set WIRESHARK_BASE_DIR=%CD%
set WIRESHARK_QT6_PREFIX_PATH=$QT_ROOT_DIR
set WERROR=y
set ENABLE_MINIZIPNG=Off
call scripts\cmake.bat
call scripts\build.bat
shell: cmd
Expand Down

0 comments on commit f049a52

Please sign in to comment.