Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(checks): Add CSPM ID for AVD-AWS-0089 #129

Merged
merged 2 commits into from
May 14, 2024
Merged

chore(checks): Add CSPM ID for AVD-AWS-0089 #129

merged 2 commits into from
May 14, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 14, 2024 •
edited
Loading

@simar7 simar7 requested a review from nikpivkin May 14, 2024 04:30
@simar7 simar7 mentioned this pull request May 14, 2024
Closed
2 tasks
@RobinFrcd
Copy link

https://avd.aquasec.com/misconfig/aws/s3/avd-aws-0091/: aws-s3-ignore-public-acls

@simar7
Copy link
Member Author

simar7 commented May 14, 2024

https://avd.aquasec.com/misconfig/aws/s3/avd-aws-0091/: aws-s3-ignore-public-acls

We already ignore by LongID() which is defined here

If this LongID isn't being ignored, we have a different bug to fix that is not related to aliasing.

@simar7 simar7 enabled auto-merge May 14, 2024 21:05
@simar7 simar7 disabled auto-merge May 14, 2024 21:05
@simar7 simar7 merged commit 7e2b879 into main May 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinFrcd RobinFrcd RobinFrcd approved these changes

@nikpivkin nikpivkin Awaiting requested review from nikpivkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simar7 @RobinFrcd