chore: store examples in YAML #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
force-pushed
the
examples-yaml
branch
2 times, most recently
from
c6aebb2
to
9c789af
Compare
|
Will be ready for review after the release of Trivy v0.57 |
nikpivkin
force-pushed
the
examples-yaml
branch
from
a55cf43
to
d947656
Compare
Signed-off-by: Nikita Pivkin <[email protected]>
nikpivkin
force-pushed
the
examples-yaml
branch
from
d947656
to
25a3a83
Compare
|
One thing to keep in mind with the examples is the avd generator. I believe it uses the go files as well. Could you confirm that @nikpivkin? |
|
@simar7 I'll check, but as far as I remember avd-generator uses generated md files. |
|
avd-generator uses only generated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
cf.goandtf.gotoyaml,Although all the examples for a single check are in a single file, we need to reference it from multiple check fields. I suggest adding a new
examplesfield that will point to a single file, while maintaining support for the current method of referencing examples for backwards compatibility.Old example files will be deleted in another PR as they are still referenced by Go checks.