fix(google): do not check flow logs on proxy-only subnets #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Nov 21, 2023
| @@ -75,6 +75,7 @@ func Test_adaptNetworks(t *testing.T) { | |||
| Metadata: defsecTypes.NewTestMetadata(), | |||
| Name: defsecTypes.String("test-subnetwork", defsecTypes.NewTestMetadata()), | |||
| EnableFlowLogs: defsecTypes.Bool(true, defsecTypes.NewTestMetadata()), | |||
| Purpose: defsecTypes.StringDefault("PRIVATE_RFC_1918", defsecTypes.NewTestMetadata()), | |||
There was a problem hiding this comment.
can we use the const?
Suggested change
| Purpose: defsecTypes.StringDefault("PRIVATE_RFC_1918", defsecTypes.NewTestMetadata()), | |
| Purpose: defsecTypes.StringDefault(defaultSubnetPurpose, defsecTypes.NewTestMetadata()), |
There was a problem hiding this comment.
Actually never mind, I see this is a test so we should have it fail in case we ever decide to change the const. Your implementation is correct.
simar7
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aquasecurity/trivy#5243
Proxy-only subnets don't support VPC Flow Logs.
Ref:
Related PRs: