fix(cloudformation): fix some resources #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
reviewed
Jan 16, 2024
| @@ -0,0 +1,66 @@ | |||
| package ec2 | |||
There was a problem hiding this comment.
nit: typo in file name, should be adapt_test.go
simar7
reviewed
Jan 16, 2024
| Enabled: defsecTypes.BoolDefault(false, clusterResource.Metadata()), | ||
| KMSKeyID: defsecTypes.StringDefault("", clusterResource.Metadata()), | ||
| Enabled: clusterResource.GetBoolProperty("PerformanceInsightsEnabled"), | ||
| KMSKeyID: clusterResource.GetStringProperty("PerformanceInsightsKmsKeyId"), |
There was a problem hiding this comment.
should this be the following?
Suggested change
| KMSKeyID: clusterResource.GetStringProperty("PerformanceInsightsKmsKeyId"), | |
| KMSKeyID: clusterResource.GetStringProperty("PerformanceInsightsKMSKeyId"), |
There was a problem hiding this comment.
Either way, we should add it to the test case so we can cover it.
There was a problem hiding this comment.
Must be PerformanceInsightsKmsKeyId
There was a problem hiding this comment.
Updated the tests
nikpivkin
force-pushed
the
cf-resources
branch
from
b405917
to
f7d88ab
Compare
simar7
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix aquasecurity/trivy#5802
CloudFormation casts the types to the required types if possible. So a boolean property can be passed the string
"false", which will be cast to bool. We could infer the type at the parsing stage so that we don't have to worry about it later, but we don't know the type of the property and so it's not safe. We must useGetBoolPropertyto get the boolean value of the property, because this method converts the string representation of a boolean value to a boolean value.Also fixed incorrect property names and default property values.