Skip to content

Commit

Permalink
use AVDID
Browse files Browse the repository at this point in the history
  • Loading branch information
simar7 committed Oct 23, 2024
1 parent 0513137 commit 36a5573
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
10 changes: 5 additions & 5 deletions pkg/report/table/misconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,15 @@ func (r *misconfigRenderer) renderSummary(misconf types.DetectedMisconfiguration
// ID & severity
switch misconf.Severity {
case severityCritical:
r.printf("%s <red><bold>(%s): ", misconf.ID, misconf.Severity)
r.printf("%s <red><bold>(%s): ", misconf.AVDID, misconf.Severity)
case severityHigh:
r.printf("%s <red>(%s): ", misconf.ID, misconf.Severity)
r.printf("%s <red>(%s): ", misconf.AVDID, misconf.Severity)
case severityMedium:
r.printf("%s <yellow>(%s): ", misconf.ID, misconf.Severity)
r.printf("%s <yellow>(%s): ", misconf.AVDID, misconf.Severity)
case severityLow:
r.printf("%s (%s): ", misconf.ID, misconf.Severity)
r.printf("%s (%s): ", misconf.AVDID, misconf.Severity)
default:
r.printf("%s <blue>(%s): ", misconf.ID, misconf.Severity)
r.printf("%s <blue>(%s): ", misconf.AVDID, misconf.Severity)
}

// heading
Expand Down
11 changes: 6 additions & 5 deletions pkg/report/table/misconfig_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ func TestMisconfigRenderer(t *testing.T) {
MisconfSummary: &types.MisconfSummary{Successes: 0, Failures: 1, Exceptions: 0},
Misconfigurations: []types.DetectedMisconfiguration{
{
ID: "AVD-XYZ-0123",
ID: "some-alias-for-a-check",
AVDID: "AVD-XYZ-0123",
Title: "Config file is bad",
Description: "Your config file is not good.",
Message: "Oh no, a bad config.",
Expand Down Expand Up @@ -61,7 +62,7 @@ See https://google.com/search?q=bad%20config
MisconfSummary: &types.MisconfSummary{Successes: 0, Failures: 1, Exceptions: 0},
Misconfigurations: []types.DetectedMisconfiguration{
{
ID: "AVD-XYZ-0123",
AVDID: "AVD-XYZ-0123",
Title: "Config file is bad",
Description: "Your config file is not good.",
Message: "Oh no, a bad config.",
Expand Down Expand Up @@ -126,7 +127,7 @@ See https://google.com/search?q=bad%20config
MisconfSummary: &types.MisconfSummary{Successes: 1, Failures: 1, Exceptions: 0},
Misconfigurations: []types.DetectedMisconfiguration{
{
ID: "AVD-XYZ-0123",
AVDID: "AVD-XYZ-0123",
Title: "Config file is bad",
Description: "Your config file is not good.",
Message: "Oh no, a bad config.",
Expand Down Expand Up @@ -157,7 +158,7 @@ See https://google.com/search?q=bad%20config
},
},
{
ID: "AVD-XYZ-0456",
AVDID: "AVD-XYZ-0456",
Title: "Config file is bad again",
Description: "Your config file is still not good.",
Message: "Oh no, a bad config AGAIN.",
Expand Down Expand Up @@ -213,7 +214,7 @@ See https://google.com/search?q=bad%20config
{
Type: "Terraform Security Check",
ID: "AVD-AWS-0107",
AVDID: "AVS-AWS-0107",
AVDID: "AVD-AWS-0107",
Title: "An ingress security group rule allows traffic from /0",
Description: "Opening up ports to the public internet is generally to be avoided. You should restrict access to IP addresses or ranges that explicitly require it where possible.",
Message: "Security group rule allows ingress from public internet.",
Expand Down

0 comments on commit 36a5573

Please sign in to comment.