Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(report): Add CreatedAt to the JSON report. (#5542) #5549

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat(report): Add CreatedAt to the JSON report. (#5542) #5549

merged 3 commits into from
Nov 15, 2023

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Nov 9, 2023

Description

Add CreatedAt to the JSON report.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

simar7
simar7 reviewed Nov 10, 2023
View reviewed changes
pkg/cloud/aws/commands/run_test.go Outdated
@@ -1125,6 +1129,7 @@ Summary Report for compliance: my-custom-spec
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
clock.SetFakeTime(t, time.Date(2021, 8, 25, 12, 20, 30, 5, time.UTC))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this particular timestamp?

Copy link
Contributor Author

@u5surf u5surf Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simar7
It doesn't specify this date intendly. I consider that it just imitates the conventional test code with clock.SetFakeTime.
It will be fine to be used any date.

knqyf263
knqyf263 reviewed Nov 13, 2023
View reviewed changes
pkg/report/writer.go Outdated Show resolved Hide resolved
@knqyf263
Copy link
Collaborator

You need to update integration tests as well. Add SetFakeTime and update golden files with mage test:updateGolden. You can run those tests with mage test:integration.

@knqyf263
Copy link
Collaborator

I completely forgot about the module/VM tests. I've updated them.

knqyf263
knqyf263 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to change the type of CreatedAt from int to time.Time, but we can change it later.

@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into aquasecurity:main with commit f4dd062 Nov 15, 2023
17 checks passed
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 left review comments

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a timestamp to the vulnerability report
4 participants
@u5surf @CLAassistant @knqyf263 @simar7