Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): add escaping for Sarif format #5568

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(report): add escaping for Sarif format #5568

merged 1 commit into from
Nov 15, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Nov 14, 2023 •
edited
Loading

Description

See #5559

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 14, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 14, 2023 06:01
knqyf263
knqyf263 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just trust you 😄

@knqyf263 knqyf263 added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@knqyf263
Copy link
Collaborator

@DmitriyLewen We're still suffering from the flaky test.
https://github.com/aquasecurity/trivy/actions/runs/6860516776/job/18654483392

@pragmaticivan
Copy link

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into aquasecurity:main with commit 5372067 Nov 15, 2023
15 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/add-escaping-for-sarif branch December 19, 2023 07:40
@DmitriyLewen DmitriyLewen mentioned this pull request Jan 9, 2024
Merged
7 tasks
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sarif json is not escaping \n on results.message.text
3 participants
@DmitriyLewen @knqyf263 @pragmaticivan