Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secret): exclude upper case before secret for alibaba-access-key-id #5618

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Nov 21, 2023

Description

We must exclude not only lowercase letters before secret for alibaba-access-key-id

example of false detection:

HIGH: Alibaba (alibaba-access-key-id)
════════════════════════════════════════════════════════════════════════════════
Alibaba AccessKey ID
────────────────────────────────────────────────────────────────────────────────
 /react-formated.json:1642
────────────────────────────────────────────────────────────────────────────────
1640             {
1641               "keyid": "SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA",
1642 [             "sig": "MEUCIQC0Ubckc7iPyGhNj6HiKnI59zSVYODr1m1ktU9m9KE************************Y1iWNzsymnlUJhtC90UWyHMc="
1643             }

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Nov 21, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review November 21, 2023 05:57
@knqyf263 knqyf263 added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@knqyf263 knqyf263 added this pull request to the merge queue Nov 22, 2023
Merged via the queue into aquasecurity:main with commit b1dc60b Nov 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False alibaba-access-key-id detection in pnpm cache for @types/react.json
2 participants