Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Go to 1.21 #5662

Merged
merged 3 commits into from
Nov 28, 2023
Merged

chore: bump Go to 1.21 #5662

merged 3 commits into from
Nov 28, 2023

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Nov 27, 2023

Description

Trivy has a policy supporting the last two major releases, just as Go does. This was mainly for reasons within our organization, but now that Go has introduced better forward compatibility in Go 1.21, it looks like we can remove this policy.
https://go.dev/blog/toolchain

This PR bumps Go to 1.21. After Go 1.21, we no longer need to care about the old stable version as Go automatically downloads the necessary toolchain. Therefore, this PR also updates some workflows.
https://go.dev/doc/toolchain

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: knqyf263 <[email protected]>
@knqyf263 knqyf263 self-assigned this Nov 27, 2023
@knqyf263 knqyf263 marked this pull request as ready for review November 28, 2023 00:31
@DmitriyLewen
Copy link
Contributor

Perhaps we can also use go-mod-file for unit tests:

go-version: oldstable

@knqyf263
Copy link
Collaborator Author

@DmitriyLewen
Copy link
Contributor

hm... sorry for confusing...
I mixed up workflow files names 😄

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Nov 28, 2023
Merged via the queue into aquasecurity:main with commit 075d8f6 Nov 28, 2023
14 checks passed
@knqyf263 knqyf263 deleted the go121 branch November 28, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants