Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): hide empty table when all secrets/license/misconfigs are ignored #7171

Merged

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jul 16, 2024

Description

We added hiding empty tables for suppressed vulnerabilities in #6352.
This PR hides tables for ignored secrets, licenses and misconfigurations

Before:

...
2024-07-16T13:36:54+06:00       DEBUG   Ignored id="MIT" target="package-lock.json"

Dockerfile (dockerfile)

Tests: 27 (SUCCESSES: 26, FAILURES: 0, EXCEPTIONS: 1)
Failures: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)


aws-secrets.txt (secrets)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)


package-lock.json (license)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

┌─────────┬─────────┬────────────────┬──────────┐
│ Package │ License │ Classification │ Severity │
└─────────┴─────────┴────────────────┴──────────┘

Process finished with the exit code 0

after:

2024-07-16T13:36:54+06:00       DEBUG   Ignored id="MIT" target="package-lock.json"

Process finished with the exit code 0

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jul 16, 2024
@DmitriyLewen DmitriyLewen changed the title fixskip empty table when ignored fix: hide empty table when all secrets/license/misconfigs are ignored Jul 16, 2024
@DmitriyLewen DmitriyLewen changed the title fix: hide empty table when all secrets/license/misconfigs are ignored fix(report): hide empty table when all secrets/license/misconfigs are ignored Jul 16, 2024
@DmitriyLewen DmitriyLewen force-pushed the fix/skip-empty-table-when-ignored branch from 48f8f32 to 4b1e1c8 Compare July 16, 2024 07:44
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 16, 2024 08:08
@DmitriyLewen
Copy link
Contributor Author

@knqyf263 @simar7 review this PR, when you have time, please.

@knqyf263 knqyf263 enabled auto-merge July 25, 2024 09:41
@knqyf263 knqyf263 added this pull request to the merge queue Jul 25, 2024
Merged via the queue into aquasecurity:main with commit c3036de Jul 25, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/skip-empty-table-when-ignored branch July 25, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report is not empty even if there are no findings: Part 2
4 participants