Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): scanning support for YAML and JSON #7311

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 6, 2024

Description

This PR adds the ability to scan arbitrary YAML or JSON files. See documentation.

Changes:

  • Enable scanning of YAML and JSON files.
  • Disable YAML and JSON scanners by default, as Trivy does not have built-in checks for configuration files of this type.
  • Add config-file-schemas flag for filtering JSON and YAML files and type checking in Rego checks.

Usage:
trivy config --misconfig-scanners=json,yaml --config-check ./serverless.rego --check-namespaces user --config-file-schemas ./serverless-schema.json ./iac

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: nikpivkin <[email protected]>
@nikpivkin nikpivkin requested a review from itaysk August 12, 2024 11:46
@nikpivkin nikpivkin marked this pull request as ready for review August 12, 2024 11:47
pkg/iac/detection/detect.go Outdated Show resolved Hide resolved
@simar7 simar7 added this pull request to the merge queue Aug 20, 2024
Merged via the queue into aquasecurity:main with commit efdbd8f Aug 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(misconf): Support arbitrary file types with custom schema
2 participants