fix(misconf): escape all special sequences #7558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
simar7
reviewed
Sep 26, 2024
Comment on lines
+169
to
+193
| func escapeSpecialSequences(input string) string { | ||
| var sb strings.Builder | ||
| sb.Grow(len(input)) | ||
| for i, r := range input { | ||
| if r == '$' || r == '%' { | ||
| sb.WriteRune(r) | ||
| remain := input[i+1:] | ||
|
|
||
| // it's not a special sequence | ||
| if remain == "" || remain[0] != '{' { | ||
| continue | ||
| } | ||
|
|
||
| // sequence is already escaped | ||
| if i > 0 && rune(input[i-1]) == r { | ||
| continue | ||
| } | ||
|
|
||
| sb.WriteRune(r) | ||
| } else { | ||
| sb.WriteRune(r) | ||
| } | ||
| } | ||
| return sb.String() | ||
| } |
There was a problem hiding this comment.
I wonder if hashicorp already has this logic somewhere that we could borrow?
There was a problem hiding this comment.
could you cite the source in that case?
There was a problem hiding this comment.
There's not much left of the source https://github.com/hashicorp/hcl/blob/main/hclwrite/generate.go#L367-L373
simar7
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Checklist