feat(parser): ignore white space in pom.xml files #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM. I'd wait for @DmitriyLewen as he has more knowledge around Maven.
DmitriyLewen
requested changes
Oct 16, 2024
|
hm... tests didn't start... |
It happens when creating the data structures and does not modify the file itself. It makes the parser behave in the same manner as maven. Signed-off-by: Samuel Gaist <[email protected]>
Signed-off-by: Samuel Gaist <[email protected]>
Signed-off-by: Samuel Gaist <[email protected]>
The property was not correctly used. Signed-off-by: Samuel Gaist <[email protected]>
sgaist
force-pushed
the
7658-trim-spaces-loading-pom
branch
from
69b587d
to
a8a9d26
Compare
DmitriyLewen
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the
pom.xmlparser so that the content of the fields are trimmed. It makes the parser behave in the same manner as maven.Related issues
pom.xmlfields #7658Checklist