refactor(misconf): Deprecate EXCEPTIONS for misconfiguration scanning

[simar7]

Description

Deprecate EXCEPTIONS for misconfiguration scanning

Usage

Before

main.tf (terraform)

Tests: 8 (SUCCESSES: 0, FAILURES: 7, EXCEPTIONS: 1)
Failures: 7 (UNKNOWN: 0, LOW: 2, MEDIUM: 1, HIGH: 4, CRITICAL: 0)

HIGH: No public access block so not blocking public acls

After

main.tf (terraform)

Tests: 7 (SUCCESSES: 0, FAILURES: 7)
Failures: 7 (UNKNOWN: 0, LOW: 2, MEDIUM: 1, HIGH: 4, CRITICAL: 0)

HIGH: No public access block so not blocking public acls

NB Ignores are still listed as part of the regular log output

2024-10-23T13:46:30-06:00       INFO    [terraform executor] Ignore finding     rule="aws-s3-encryption-customer-key" range="main.tf:13-21"

Related stuff

• DEPRECATION: Dropping support for `EXCEPTIONS` in misconfiguration results #7474
• Close BREAKING(report): Drop support for EXCEPTIONS from results #7314

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[DmitriyLewen]

IIUC we can mark exceptions as reserved:

trivy/rpc/common/service.proto

Line 76 in 4926da7

repeated MisconfResult exceptions = 6;

[simar7]

thanks! I updated it.

[DmitriyLewen]

lgtm