Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lint errors.Join #7845

Merged
merged 2 commits into from
Oct 31, 2024
Merged

chore: lint errors.Join #7845

merged 2 commits into from
Oct 31, 2024

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Oct 31, 2024 •
edited
Loading

Description

hashicorp/go-multierror.Append displays more user-friendly errors than errors.Join.
https://go.dev/play/p/AYls8a96t-j

[errors.Join]
err1
err2

[go-multierror.Append]
2 errors occurred:
	* err1
	* err2

This PR adds a new lint rule as the usage should be consistent in the project.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Oct 31, 2024
@knqyf263 knqyf263 changed the title Lint errors join chore: lint errors.Join Oct 31, 2024
@knqyf263 knqyf263 marked this pull request as ready for review October 31, 2024 11:45
DmitriyLewen
DmitriyLewen approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into aquasecurity:main with commit 7632625 Oct 31, 2024
12 of 15 checks passed
@knqyf263 knqyf263 deleted the lint_errors_join branch October 31, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@simar7 simar7 Awaiting requested review from simar7 simar7 is a code owner

@nikpivkin nikpivkin Awaiting requested review from nikpivkin nikpivkin is a code owner

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knqyf263 @DmitriyLewen