Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(arns): add lua type docs and update tests for arns.lua #162

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

dtfiedler
Copy link
Collaborator

A series of changes will come to add docs to functions and standardize our error logic

A series of changes will come to add docs to functions and standardize our error logic
@dtfiedler dtfiedler requested review from vilenarios and arielmelendez and removed request for vilenarios November 5, 2024 02:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 93.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.93%. Comparing base (fcef672) to head (0a748b0).

Files with missing lines Patch % Lines
src/arns.lua 96.29% 2 Missing ⚠️
src/demand.lua 50.00% 2 Missing ⚠️
src/epochs.lua 33.33% 2 Missing ⚠️
src/utils.lua 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           PE-5712_allowed_delegates     #162      +/-   ##
=============================================================
+ Coverage                      89.58%   89.93%   +0.35%     
=============================================================
  Files                              9        9              
  Lines                           2045     2027      -18     
=============================================================
- Hits                            1832     1823       -9     
+ Misses                           213      204       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arielmelendez arielmelendez merged commit 7a349a5 into PE-5712_allowed_delegates Nov 5, 2024
5 checks passed
@arielmelendez arielmelendez deleted the lua-docs-arns branch November 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants