feat: init arns discount elgibility and fee caclulation PE-7060 #164
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #164 +/- ##
===========================================
+ Coverage 90.84% 90.90% +0.06%
===========================================
Files 9 9
Lines 1966 1991 +25
===========================================
+ Hits 1786 1810 +24
- Misses 180 181 +1 ☔ View full report in Codecov by Sentry. |
| local tenureWeight = gateway.weights.tenureWeight | ||
| local gatewayPerformanceRatio = gateway.weights.gatewayRewardRatioWeight |
There was a problem hiding this comment.
nit: this shouldn't happen, but lua throws up when comparing numbers to nil so I would add or 0 to both of these
There was a problem hiding this comment.
look good!
look into adding an integration test to gar.test.mjs - you can use @arielmelendez current branch for how to set up state with a gateway and then call handlers like buy-record and get-token-cost to validate the discount is applied for operators if they achieve the thresholds defined in the process. happy to pair on it speed up iterations.
No description provided.