feat(bundles): increment import_attempt_count when skipping bundles

[karlprieb]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.62%. Comparing base (d2eb5e5) to head (79d3e7c).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #278   +/-   ##
========================================
  Coverage    71.62%   71.62%           
========================================
  Files           37       37           
  Lines         9361     9361           
  Branches       537      537           
========================================
  Hits          6705     6705           
  Misses        2652     2652           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

error @permaweb/[email protected]: The engine "yarn" is incompatible with this module. Expected version "please-use-npm". Got "1.22.22"
error Found incompatible module.

📝 Walkthrough

Walkthrough

The pull request modifies the SQL import logic in the database to change how import_attempt_count and duplicated_data_item_count are calculated. The key change is expanding the condition for incrementing these values from only checking queued_at to now also considering skipped_at. This means the import attempt count and duplication tracking will now trigger under a broader set of circumstances, potentially providing more comprehensive tracking of bundle and data item import processes.

Changes

File	Change Summary
src/database/sql/bundles/import.sql	Updated upsertBundle and related operations to increment import_attempt_count when either @queued_at or @skipped_at is not null
src/database/standalone-sqlite.test.ts	Added new test cases and constants to validate the updated import attempt count logic, including a new bundle ID and SQL query for bundle selection

Sequence Diagram

sequenceDiagram
    participant DB as Database
    participant Bundle as Bundle Import
    
    Bundle->>DB: Attempt Import
    alt Queued or Skipped
        DB->>DB: Increment import_attempt_count
        DB->>DB: Update duplicated_data_item_count
    else Neither Queued nor Skipped
        DB->>DB: No Count Increment
    end

Loading

Possibly related PRs

• feat(sql): add import_attempt_count column to bundles #129: Added import_attempt_count column to bundles table
• feat(bundles): add duplicated data item count #275: Introduced duplicated_data_item_count column to bundles table

Suggested reviewers

• djwhitt

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2eb5e5 and 79d3e7c.

📒 Files selected for processing (2)

• src/database/sql/bundles/import.sql (2 hunks)
• src/database/standalone-sqlite.test.ts (4 hunks)

🔇 Additional comments (8)

src/database/sql/bundles/import.sql (2)

19-19: LGTM! Initial import_attempt_count logic correctly handles both queued and skipped states.

The condition CASE WHEN (@queued_at IS NOT NULL OR @skipped_at IS NOT NULL) THEN 1 ELSE 0 END properly initializes the counter when a bundle is either queued or skipped.

---

Line range hint 36-40: LGTM! Import attempt increment logic is consistent with initialization.

The update logic correctly increments the counter when either queued or skipped, maintaining consistency with the initial import_attempt_count logic.

src/database/standalone-sqlite.test.ts (6)

1028-1028: LGTM! Clear and descriptive test constant.

The constant id2 follows the established pattern of test IDs.

---

1037-1042: LGTM! SQL query extracted as a reusable constant.

Good practice to define the SQL query once for reuse across multiple test cases.

---

1051-1055: LGTM! Test setup includes skipped bundle case.

The test setup now includes a bundle with skippedAt to test the new functionality.

---

1068-1075: LGTM! Comprehensive test coverage for import_attempt_count initialization.

Tests verify that:

1. Count is 0 when neither queuedAt nor skippedAt is provided
2. Count is 1 when either queuedAt or skippedAt is provided

Also applies to: 1076-1089

---

1090-1112: LGTM! Test verifies import_attempt_count is not incremented unnecessarily.

Test ensures the count doesn't increment when neither queuedAt nor skippedAt is provided in subsequent saves.

---

1113-1135: LGTM! Test verifies import_attempt_count increment behavior.

Test confirms that the count increments correctly when either queuedAt or skippedAt is provided in subsequent saves.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.