docs(Diagrams): Added puml diagrams. PE-4847 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #63 +/- ##
===========================================
+ Coverage 56.56% 57.00% +0.44%
===========================================
Files 18 18
Lines 5164 5373 +209
Branches 244 260 +16
===========================================
+ Hits 2921 3063 +142
- Misses 2241 2306 +65
- Partials 2 4 +2 ☔ View full report in Codecov by Sentry. |
djwhitt
reviewed
Nov 30, 2023
There was a problem hiding this comment.
@Bobinstein Nice work. The changes and additional diagrams are good. I added comments with some suggested adjustments.
djwhitt
reviewed
Dec 8, 2023
There was a problem hiding this comment.
@Bobinstein You removed a little more detail in one place than I intended (see inline comment). I should have been more specific in my wording there. All the other changes look good. Add back some of that original detail along with the suggested wording change and I think this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.