PE-4908 Add support for range requests #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #64 +/- ##
===========================================
+ Coverage 56.56% 57.72% +1.16%
===========================================
Files 18 18
Lines 5164 5280 +116
Branches 244 260 +16
===========================================
+ Hits 2921 3048 +127
+ Misses 2241 2228 -13
- Partials 2 4 +2 ☔ View full report in Codecov by Sentry. |
- Reduces duplicated header logic. - Replaces custom range parsing code with the range-parser library in order to handle the full range parsing spec. - Handles range errors case (malformed, unsatisfiable range) with appropriate status codes. - Responds to requests for multiple ranges with 200 and full data (we're not yet supporting multiple ranges). Multiple ranges will be fully supported once we've integrated range handling into `getData`. In the meantime we should watch out for clients that get confused by how we're currently handling them.
Adds some basic range requets tests to ensure that the expected range data is returned and requests for multiple ranges are responded to with a 200 + full data.
djwhitt
force-pushed
the
PE-4908-range-request-integration
branch
from
9f80b9c to
e070006
Compare
…4908 Since we're not fully supporting multiple range requets yet, we were initially returning 200 along with full data for them requests. However, it was pointed out that despite the 200 status code, clients may not handle this correctly. This is likely the case, so this commit switches the 200 to 416 (without data) for clarity. This commit also switches some log messages for invalid ranges from errors to warnings. We're trying to reserve error messages for potential issues (bugs or ops problems). Invalid user input doesn't qualify.
djwhitt
force-pushed
the
PE-4908-range-request-integration
branch
from
e070006 to
753c5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for range requests excluding requests for multiple ranges which are currently handled by returning 200 (rather than 206) with full data in the body. Multiple ranges will be fully supported once we've integrated range handling into
getData.