-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow plain strings in defines #27
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! I am somewhat unsure about this change, as it would change the user experience on typos. Is there any use case, where the additional quoting causes significant problems (apart of convenience)? |
I think the issue is that it counter to how the compilers are using As for the use-case, this will allow to transparently pass the pre-compile flags from one target to the other, e.g. in the cmake: |
I agree, that it was probably counterintuitive to abuse What about an extra option to settle this? Something like |
Indeed that would work. I would add though that there should be a deprecation message and transition for |
OK, let's do the following:
I'd need some time, though, to implement it. |
- For backwards compatibility, -D will continue to be interpreted as Python expression until 4.0 - Introduced a temporary variable -d/--define-value-type to switch to the proper interpretation when set to `str` Signed-off-by: Cristian Le <[email protected]>
e5075cf
to
a2baf28
Compare
This allows to pass
-DFOO=some_value