Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-752 | multi_delimiter analyzer [3.12] #322

Merged
merged 8 commits into from
Apr 24, 2024
Merged

DE-752 | multi_delimiter analyzer [3.12] #322

merged 8 commits into from
Apr 24, 2024

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Feb 2, 2024

Can be merged after 3.12 image is introduced

tested to work locally with 3.12.0-NIGHTLY.20240305

tests/test_analyzer.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (d5d867c) to head (6e5bc34).

❗ Current head 6e5bc34 differs from pull request most recent head ac2dd4a. Consider uploading reports for the commit ac2dd4a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   98.00%   98.15%   +0.14%     
==========================================
  Files          26       26              
  Lines        4261     4219      -42     
==========================================
- Hits         4176     4141      -35     
+ Misses         85       78       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aMahanna aMahanna marked this pull request as draft February 2, 2024 22:07
@aMahanna aMahanna changed the title wip: DE-752 wip: DE-752 [3.12] Feb 2, 2024
tests/test_analyzer.py Outdated Show resolved Hide resolved
@aMahanna aMahanna changed the title wip: DE-752 [3.12] DE-752 [3.12] Mar 8, 2024
@aMahanna aMahanna changed the title DE-752 [3.12] DE-752 | multi_delimiter analyzer [3.12] Mar 8, 2024
@aMahanna aMahanna marked this pull request as ready for review April 22, 2024 21:06
Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aMahanna aMahanna merged commit af582cf into main Apr 24, 2024
1 of 35 checks passed
@aMahanna aMahanna deleted the DE-752 branch April 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants