add support for sort in collection.find function

[denizalpaslan]

add support for sorting by multiple fields in collection.find function

[apetenchea]

I like the idea!

Left some remarks, but nothing major.

[apetenchea]

The docstring says DocumentGetError, but the function raises DocumentParseError. I think it's better to create a new error type, inheriting ArangoClientError in exceptions.py, use that and fix the docstring (for example, SortValidationError).

[denizalpaslan]

Done. I created a new section (Parameter Validation Exceptions) under exceptions.py, which can come handy for other types of validation errors (filter etc.) in the future.

[apetenchea]

Thanks!
Please update the docstring of this function using the newly created SortValidationError, along with the two raise statements at lines 143 and 147.

[denizalpaslan]

So I see one of the tests (tests/test_cursor.py::test_cursor_from_execute_query[db0]) is failing for some python versions. Not sure if this is pertinent to my change but for the first commit they were not failing. Same test is passing on my local env (python 3.12.4). Any idea?

[apetenchea]

So I see one of the tests (tests/test_cursor.py::test_cursor_from_execute_query[db0]) is failing for some python versions. Not sure if this is pertinent to my change but for the first commit they were not failing. Same test is passing on my local env (python 3.12.4). Any idea?

Don't worry about these failing tests, they are unrelated. I'll fix them in #360

[apetenchea]

Only validate_sort_parameters remains to be fixed, with regards to raising exceptions.

[apetenchea]

Thanks!
Please update the docstring of this function using the newly created SortValidationError, along with the two raise statements at lines 143 and 147.

[apetenchea]

In order to merge, please make sure linter is passing

arango/collection.py:789: error: Argument 1 to "build_sort_expression" has incompatible type "list[dict[str, Any]] | None"; expected "list[dict[str, Any]]"  [arg-type]
Found 1 error in 1 file (checked 27 source files)

[denizalpaslan]

In order to merge, please make sure linter is passing

arango/collection.py:789: error: Argument 1 to "build_sort_expression" has incompatible type "list[dict[str, Any]] | None"; expected "list[dict[str, Any]]"  [arg-type]
Found 1 error in 1 file (checked 27 source files)

Done. Linter seems to be passing now.

[apetenchea]

LGTM